Added missing unit tests

braintree · Dec 17, 2024 · 590ad21 · 590ad21
1 parent 4c61f94
commit 590ad21
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 4 deletions.
diff --git a/Sources/BraintreeShopperInsights/BTExperimentType.swift b/Sources/BraintreeShopperInsights/BTExperimentType.swift
@@ -14,7 +14,7 @@ public enum BTExperimentType: String {
         """
             [
                 { "exp_name" : "PaymentReady" }
-                { "treatment_name" : \(self.rawValue) }
+                { "treatment_name" : "\(self.rawValue)" }
             ]
         """
     }

diff --git a/Sources/BraintreeShopperInsights/BTShopperInsightsClient.swift b/Sources/BraintreeShopperInsights/BTShopperInsightsClient.swift
@@ -102,7 +102,8 @@ public class BTShopperInsightsClient {
             buttonOrder: presentmentDetails.buttonOrder.rawValue,
             buttonType: buttonType.rawValue,
             experimentType: presentmentDetails.experimentType.formattedExperiment,
-            pageType: presentmentDetails.pageType.rawValue
+            pageType: presentmentDetails.pageType.rawValue,
+            shopperSessionID: shopperSessionID
         )
     }
 

diff --git a/UnitTests/BraintreeShopperInsightsTests/BTShopperInsightsClient_Tests.swift b/UnitTests/BraintreeShopperInsightsTests/BTShopperInsightsClient_Tests.swift
@@ -216,7 +216,13 @@ class BTShopperInsightsClient_Tests: XCTestCase {
         XCTAssertEqual(mockAPIClient.postedAnalyticsEvents.first, "shopper-insights:button-presented")
         XCTAssertEqual(mockAPIClient.postedButtonOrder, 0)
         XCTAssertEqual(mockAPIClient.postedButtonType, "PayPal")
-        XCTAssertEqual(mockAPIClient.postedExperimentType, "control")
+        XCTAssertEqual(mockAPIClient.postedExperimentType,
+        """
+            [
+                { "exp_name" : "PaymentReady" }
+                { "treatment_name" : "control" }
+            ]
+        """)
         XCTAssertEqual(mockAPIClient.postedPageType, "about")
     }
 
@@ -236,7 +242,13 @@ class BTShopperInsightsClient_Tests: XCTestCase {
         XCTAssertEqual(mockAPIClient.postedAnalyticsEvents.first, "shopper-insights:button-presented")
         XCTAssertEqual(mockAPIClient.postedButtonOrder, 0)
         XCTAssertEqual(mockAPIClient.postedButtonType, "Venmo")
-        XCTAssertEqual(mockAPIClient.postedExperimentType, "control")
+        XCTAssertEqual(mockAPIClient.postedExperimentType,
+        """
+            [
+                { "exp_name" : "PaymentReady" }
+                { "treatment_name" : "control" }
+            ]
+        """)
         XCTAssertEqual(mockAPIClient.postedPageType, "about")
     }
 

diff --git a/UnitTests/BraintreeTestShared/MockAPIClient.swift b/UnitTests/BraintreeTestShared/MockAPIClient.swift
@@ -113,6 +113,10 @@ public class MockAPIClient: BTAPIClient {
         payPalContextID: String? = nil,
         shopperSessionID: String? = nil
     ) {
+        postedButtonType = buttonType
+        postedButtonOrder = buttonOrder
+        postedExperimentType = experimentType
+        postedPageType = pageType
         postedPayPalContextID = payPalContextID
         postedLinkType = linkType
         postedIsVaultRequest = isVaultRequest ?? false
-Original file line number
+Diff line change
@@ Expand Up / @@ -14,7 +14,7 @@ public enum BTExperimentType: String { @@
             """
                 [
                     { "exp_name" : "PaymentReady" }
-                    { "treatment_name" : \(self.rawValue) }
+                    { "treatment_name" : "\(self.rawValue)" }
                 ]
             """
         }
@@ Expand Down @@