Add cardAddChallengeRequested to BTThreeDSecureRequest
#1122
Conversation
| @@ -49,6 +49,7 @@ import BraintreeCore | |||
| /// Non-Mastercard cardholders will fallback to a normal 3DS flow. | |||
| public var dataOnlyRequested: Bool = false | |||
|
|
|||
| // NEXT_MAJOR_VERSION remove cardAddChallenge in favor of cardAddChallengeRequested | |||
There was a problem hiding this comment.
Can we deprecate this param also and direct merchants to set cardAddChallengeRequested instead?
There was a problem hiding this comment.
I had initially but apparently it blows up cocoapods unless you allow warnings (CI failure here) which I don't think we want merchants doing. 😞 It was removed here: 04c8c69
There was a problem hiding this comment.
😢 One of the cons for moving to Swift is that there is no macro for silencing deprecation warnings in-line. We already saw this limitation a bit when trying to deprecate the start() method on PPCP (PR).
I guess we can only deprecate something if it isn't used anywhere in our source code, to avoid warnings to be triggered. There might be some (slightly wonky) workaround we can do in our implementation to get around this.
We could map the merchant's cardAddChallenge (deprecated) setting to an internal property (non-deprecated) so that referencing it doesn't trigger a warning.
There was a problem hiding this comment.
Yeah, it's pretty interesting to me that these attributes are pretty limited overall without allowing warnings. It'd be nice to have a cleaner way to mark properties/methods to be removed in a future version that works with all package managers. What does work is this - just tested locally and pod lib lint --subspec=ThreeDSecure passes:
#if !COCOAPODS
@available(*, deprecated, renamed: "cardAddChallengeRequested", message: "Use cardAddChallengeRequested. This property will be removed in our next major version.")
#endifNot sure how we feel about only notifying SPM + Carthage merchants. Curious to hear what y'all think.
Summary of changes
cardAddChallengeRequestedtoBTThreeDSecureRequestcardAddChallengecardAddChallengeRequestedChecklist
Authors