Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate BTCardRequest #1129

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Deprecate BTCardRequest #1129

merged 5 commits into from
Nov 3, 2023

Conversation

scannillo
Copy link
Contributor

@scannillo scannillo commented Nov 2, 2023 •
edited
Loading

Summary of changes

  • I noticed BTCardRequest is unused
  • Added deprecation warning & NEXT_MAJOR_VERSION note

Checklist

  • Added a changelog entry

Authors

@scannillo

@scannillo scannillo requested a review from a team as a code owner November 2, 2023 21:33
sarahkoop
sarahkoop approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@sarahkoop sarahkoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to deviate from Android which uses CardRequest but I think that's ok

@scannillo
Copy link
Contributor Author

@sarahkoop This is going to deviate from Android which uses CardRequest but I think that's ok

It looks like Android also uses just Card type as the input param to tokenize(). I also don't see a CardRequest type when I search in Android either.

I was surprised by this honestly, I thought we aligned all the tokenize() methods in iOS V6 to take in <PaymentMethod>Request types.

@sarahkoop
Copy link
Contributor

@sarahkoop This is going to deviate from Android which uses CardRequest but I think that's ok

It looks like Android also uses just Card type as the input param to tokenize(). I also don't see a CardRequest type when I search in Android either.

I was surprised by this honestly, I thought we aligned all the tokenize() methods in iOS V6 to take in <PaymentMethod>Request types.

Ah nevermind - I was mistaken you're right!

@scannillo scannillo merged commit e40b421 into main Nov 3, 2023
6 checks passed
@scannillo scannillo deleted the remove-btcardrequest-note branch November 3, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahkoop sarahkoop sarahkoop approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scannillo @sarahkoop @jaxdesmarais