Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Magnes 5.4.1 for Carthage #1133

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Update Magnes 5.4.1 for Carthage #1133

merged 4 commits into from
Nov 17, 2023

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

  • The version uploaded for Carthage was incorrect for Magnes 5.4.1 - this PR now pins the correctly upload version

Checklist

  • Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais marked this pull request as ready for review November 13, 2023 20:30
@jaxdesmarais jaxdesmarais requested a review from a team as a code owner November 13, 2023 20:30
@jaxdesmarais
Copy link
Contributor Author

The failing Venmo UI tests are unrelated and also failing on main

@jaxdesmarais
Copy link
Contributor Author

Waiting on the CDNX team to resolve the Magnes asset issue

@jaxdesmarais
Copy link
Contributor Author

Manges assets have been stable for 24 hours - will merge this in now that things look stable with the CDNX.

@jaxdesmarais jaxdesmarais merged commit 764ef6f into main Nov 17, 2023
6 checks passed
@jaxdesmarais jaxdesmarais deleted the v6-magnes-5.4.1-carthage branch November 17, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahkoop sarahkoop sarahkoop approved these changes

@sshropshire sshropshire sshropshire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaxdesmarais @sshropshire @sarahkoop