Add Cardinal UI Type and Render Types #1134
+137
−1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -98,6 +98,14 @@ class ThreeDSecureViewController: PaymentButtonBaseViewController { | |
| request.requestedExemptionType = .lowValue | ||
| request.email = "[email protected]" | ||
| request.shippingMethod = .sameDay | ||
| request.uiType = .both | ||
| request.renderTypes = [ | ||
| BTThreeDSecureRenderType.otp, | ||
| BTThreeDSecureRenderType.singleSelect, | ||
| BTThreeDSecureRenderType.multiSelect, | ||
| BTThreeDSecureRenderType.oob, | ||
| BTThreeDSecureRenderType.html | ||
| ] | ||
|
|
||
| let billingAddress = BTThreeDSecurePostalAddress() | ||
| billingAddress.givenName = "Jill" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import Foundation | ||
|
|
||
| /// Render types that the device supports for displaying specific challenge user interfaces within the 3D Secure challenge. | ||
| @objcMembers public class BTThreeDSecureRenderType: NSObject { | ||
|
|
||
| public typealias StringValue = String | ||
|
|
||
| /// OTP | ||
| public static let otp: StringValue = "CardinalSessionRenderTypeOTP" | ||
|
|
||
| /// HTML | ||
| public static let html: StringValue = "CardinalSessionRenderTypeHTML" | ||
|
|
||
| /// Single select | ||
| public static let singleSelect: StringValue = "CardinalSessionRenderTypeSingleSelect" | ||
|
|
||
| /// Multi Select | ||
| public static let multiSelect: StringValue = "CardinalSessionRenderTypeMultiSelect" | ||
|
|
||
| /// OOB | ||
| public static let oob: StringValue = "CardinalSessionRenderTypeOOB" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import Foundation | ||
| import CardinalMobile | ||
|
|
||
| /// The interface types that the device supports for displaying specific challenge user interfaces within the 3D Secure challenge. | ||
| @objc public enum BTThreeDSecureUIType: Int { | ||
|
|
||
| /// Native | ||
| case native | ||
|
|
||
| /// HTML | ||
| case html | ||
|
|
||
| /// Both | ||
| case both | ||
|
|
||
| var cardinalValue: CardinalSessionUIType { | ||
| switch self { | ||
| case .native: | ||
| return .native | ||
| case .html: | ||
| return .HTML | ||
| case .both: | ||
| return .both | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the
@objcannotation work for us (stack post)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works for the enum but that's not the issue, the issue is that arrays of
Intenums don't exist in Obj-C and enums can only be bridged toInttypes to be interoperable with Obj-C. A Swift array is bridged to Obj-C'sNSArray, and an Obj-C array should contain only pointers, but an enum ofIntdoesn't contain pointers so cannot be bridged.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah got it yeah. That makes sense. Swift does have
OptionSetas anNS_OPTIONSequivalent, but I can't tell if option sets are accessible from Obj-C.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 we may be able to make that work - it'll need to be a class instead of a struct since structs don't exist in Obj-c, but I think that may be okay. I'll poke around at it a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: 5911c55. Great suggestion, that's way cleaner 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also if anyone is interested this is how the implementation will look for Obj-C merchants: