Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate duplicate BTHTTP HTTP methods #1140

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Consolidate duplicate BTHTTP HTTP methods #1140

merged 2 commits into from
Dec 4, 2023

Conversation

scannillo
Copy link
Contributor

Summary of changes

  • Remove overload methods for BTHTTP.post(), .get(), and .delete()
  • Use default arg params to consolidate each CRUD method into 1, versus using method overloads

Checklist

  • Added a changelog entry

Authors

@scannillo

@scannillo scannillo requested a review from a team as a code owner December 1, 2023 18:06
@scannillo scannillo force-pushed the cleanup-bthttp-methods branch from 0e0b6c6 to 825baf6 Compare December 1, 2023 18:16
@scannillo scannillo merged commit bb00cc3 into main Dec 4, 2023
6 checks passed
@scannillo scannillo deleted the cleanup-bthttp-methods branch December 4, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahkoop sarahkoop sarahkoop approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scannillo @jaxdesmarais @sarahkoop