Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT REVIEW] Merge Contact Information Feature Branch #1495

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[DO NOT REVIEW] Merge Contact Information Feature Branch #1495

wants to merge 4 commits into from

Conversation

jaxdesmarais
Copy link
Contributor

@jaxdesmarais jaxdesmarais commented Jan 7, 2025 •
edited
Loading

Summary of changes

  • These changes were reviewed and approved previously, this is just to trigger CI and ensure all passes before merging into main

Checklist

  • Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

richherrera and others added 4 commits December 2, 2024 11:03
@richherrera @agedd
Add Contact Information request object (#1469)
54ec162 
* Add contact information struct

* Add contact information parameters to create_payment_resource

* Add UTs

* Update CHANGELOG

* Address PR feedback, update docstrings

* Add missing blank space

* Update UnitTests/BraintreePayPalTests/BTPayPalCheckoutRequest_Tests.swift

Co-authored-by: agedd <[email protected]>

---------

Co-authored-by: agedd <[email protected]>
@richherrera @jaxdesmarais
Add contact information toggle (#1475)
4469f73 
* Add contact information struct

* Add contact information parameters to create_payment_resource

* Add UTs

* Update CHANGELOG

* Address PR feedback, update docstrings

* Add contact information toggle

---------

Co-authored-by: Jax DesMarais-Leder <[email protected]>
@richherrera
Fix merge on demo app (#1478)
06969f1
@jaxdesmarais
Merge branch 'main' into contact-information-feature
a650958 
# Conflicts:
#	CHANGELOG.md
@jaxdesmarais jaxdesmarais requested a review from a team as a code owner January 7, 2025 19:12
@sarahkoop
Copy link
Contributor

Let's tag this as DO NOT MERGE until we can complete the prod testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahkoop sarahkoop sarahkoop approved these changes

Assignees
No one assigned
Labels
do not merge do not review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaxdesmarais @sarahkoop @richherrera