test: Add Python test infrastructure and OpenAI wrapper tests #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Add py-test target to Makefile - Create initial test infrastructure - Add tests for wrap_openai sync/async functionality - Verify proper type handling for OpenAI responses Co-Authored-By: [email protected] <[email protected]>
Co-Authored-By: [email protected] <[email protected]>
Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
Co-Authored-By: [email protected] <[email protected]>
Co-Authored-By: [email protected] <[email protected]>
Co-Authored-By: [email protected] <[email protected]>
…dict() Co-Authored-By: [email protected] <[email protected]>
ibolmo
reviewed
Dec 16, 2024
| api_key="sk-test", base_url="https://api.openai.com/v1/", default_headers={"OpenAI-Version": "2020-10-01"} | ||
| ) | ||
| wrapped = wrap_openai(async_client) | ||
| reveal_type(wrapped) # type: ignore # Expected type: openai.AsyncOpenAI |
There was a problem hiding this comment.
is this actually testing anything? I want the unit test not a third party tool testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test infrastructure and unit tests to verify wrap_openai async functionality and type handling.
Fixes user report about async OpenAI wrapper type issues.
Changes:
Link to Devin run: https://app.devin.ai/sessions/211194fd79ad4504b3518df6c394b00f