Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle attribute not being present on the weather entity #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

avee87
Copy link

@avee87 avee87 commented Mar 5, 2021

Sometimes weather entity doesn't have all attributes defined. Currently card will try to render them and will only show units which looks broken.
This diff essentially makes it treat all attributes as optional and doesn't show the missing ones.
Screenshot 2021-03-05 at 14 21 50
Screenshot 2021-03-05 at 14 21 05
Screenshot 2021-03-05 at 14 20 34

@regevbr
Copy link

regevbr commented Nov 9, 2021

Any news on this PR?

@avee87
Copy link
Author

avee87 commented Nov 11, 2021

Didn't realise this PR has gone stale. Rebased to the latest version.

@olekenneth
Copy link

I don't think the owner accepts PRs. Or at least doesn't answer or comment. I have one PR for a year now.

@JeanneD4RK
Copy link

Judging by the last commit date, this repo should be forked I guess..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants