Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favour default frontmatter #95

Closed
wants to merge 7 commits into from
Closed

Favour default frontmatter #95

wants to merge 7 commits into from

Conversation

sunt05
Copy link

@sunt05 sunt05 commented Oct 23, 2023

Fix #89.

Note this also includes changes in #47 and #63.

@DenizOkcu
Copy link
Collaborator

Hey @sunt05 please separate the fix for #89 from the other features in a different PR. it is way easier to review and merge without pulling in other functionality which has not yet been discussed.

@DenizOkcu DenizOkcu added the question Further information is requested label Jan 10, 2025
@sunt05
Copy link
Author

sunt05 commented Jan 10, 2025

Thank you for the feedback! I’ll separate the fix for #89 into a different PR as suggested.

@sunt05 sunt05 closed this Jan 10, 2025
@DenizOkcu
Copy link
Collaborator

DenizOkcu commented Jan 10, 2025 •
edited
Loading

Here are a few issues which your fix would possibly close:
#82 #88 #89

check if there is something helpful for you as well

@DenizOkcu
Copy link
Collaborator

@sunt05 #108 fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using gpt-4 as default not possible
3 participants
@sunt05 @DenizOkcu @szw