reverse proxy: use Rewrite instead of Director #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to mitigate Golang's behavior with `ReverseProxy.Director` when, after the outgoing request is mutated, any headers specified by "Connection" would get rmoved from the mutated request. `ReverseProxy.Rewrite()` is only called once the headers specified in "Connection" were already removed from the outgoing-to-be request.
stlaz
added
the
sig-auth-acceptance
ibihim
reviewed
Nov 16, 2024
| target := cfg.KubeRBACProxyInfo.UpstreamURL | ||
| pr.SetURL(target) | ||
| pr.Out.Host = target.Host | ||
| copyHeaderIfSet(pr.In, pr.Out, "X-Forwarded-For") |
There was a problem hiding this comment.
Wouldn't it make sense to add the IP address of the client, if not already set?
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For#syntax
There was a problem hiding this comment.
pr.SetXForwarded() does that but only if X-Forwarded-For is already set
ibihim
reviewed
Nov 16, 2024
| Rewrite: func(pr *httputil.ProxyRequest) { | ||
| target := cfg.KubeRBACProxyInfo.UpstreamURL | ||
| pr.SetURL(target) | ||
| pr.Out.Host = target.Host |
There was a problem hiding this comment.
Why do you set it, after rewrite removed it? To keep the same behavior as with the Director?
There was a problem hiding this comment.
Yes, I meant to keep the behavior the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to mitigate Golang's behavior with
ReverseProxy.Directorwhen, after the outgoing request is mutated, any headers specified by "Connection" would get rmoved from the mutated request.ReverseProxy.Rewrite()is only called once the headers specified in "Connection" were already removed from the outgoing-to-be request.Fixes #319
edit: useful resources for more context: