-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate redigo to go-redis, upgrade throttled #2737
Open
mschfh
wants to merge
4
commits into
master
Choose a base branch
from
mschfh-goredis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschfh
force-pushed
the
mschfh-goredis
branch
2 times, most recently
from
January 22, 2025 10:05
b8273b3
to
9db4ff3
Compare
clD11
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM approved with comments.
[puLL-Merge] - brave-intl/bat-go@2737 DescriptionThis PR updates Redis and rate limiter dependencies to newer versions and improves Docker build caching. The main changes involve:
ChangesChangesDockerfile
Redis Client Changes
Rate Limiter Changes
Dependency Updates
sequenceDiagram
participant App
participant RateLimiter
participant Redis
App->>RateLimiter: HTTP Request
RateLimiter->>Redis: Check Rate Limit (with context)
Redis-->>RateLimiter: Return Current Count
alt Under Limit
RateLimiter->>App: Allow Request
else Over Limit
RateLimiter->>App: Return 429 Too Many Requests
end
Security Hotspots
|
mschfh
force-pushed
the
mschfh-goredis
branch
from
January 25, 2025 09:53
e62716a
to
73bd704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces our outdated
redigo
dependency withgo-redis
.Type of Change
Tested Environments
Before Requesting Review