-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.9.0 #388
Release v0.9.0 #388
Conversation
the info has never been used, and it's trivial to check by inspecting the strings of a rule anyways.
the info is essentially an engine-internal optimization detail and won't be useful for external users of the library
[puLL-Merge] - brave/adblock-rust@388 DescriptionThis PR makes significant changes to the adblock-rust library, updating it from version 0.8.12 to 0.9.0. The main changes include improvements in handling cosmetic filters, scriptlet resources, and procedural operators. The PR also includes various refactoring and code cleanup efforts. Possible Issues
Security Hotspots
ChangesChanges
These changes represent a significant update to the library's handling of cosmetic filters and scriptlet resources, with a focus on improving support for procedural operators and more complex filter scenarios. |
} | ||
|
||
// Safe; early return if length is not 1 | ||
let selector = prelude.0.into_iter().next().unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] expect
or unwrap
called in function returning a Result
Source: https://semgrep.dev/r/trailofbits.rs.panic-in-function-returning-result.panic-in-function-returning-result
Cc @thypon @bcaller
Includes:
Procedural filtering
This is the major update everyone's been waiting for.
:style()
,:remove()
,:remove-attr()
, and:remove-class()
storage has been unified into a single filter bin as a prerequisite, since these actions can also occur on procedural filters.serde_json
is no longer an optional dependency since adblock-rust must be able to serialize these filter types to JSON.ProceduralOrActionFilter
type for further documentation.Scriptlet dependencies
fn/javascript
mimetypes for resources can now be parsed and added to the engine.API cleanup
Since this is a breaking release, there are a couple of other minor breaking API changes in the form of functionality made private and/or removed.
These were unlikely to be useful to others in the first place.