Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update actions/checkout action to v4.2.2 #199

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 30, 2024

This PR contains the following updates:

Package Type Update Change
actions/checkout action patch v4.2.1 -> v4.2.2

Release Notes

actions/checkout (actions/checkout)

v4.2.2

Compare Source


Configuration

📅 Schedule: Branch creation - "* 0-4 * * 3" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

openai debug - [puLL-Merge] - actions/[email protected]

Description

This PR introduces the following changes to the repository:

  1. Enhances the functionality of url-helper.ts to leverage well-known environment variables for improved flexibility and accuracy.
  2. Expands unit test coverage for the isGhes function, ensuring better validation of its behavior in different scenarios.
  3. Updates the package version to 4.2.2.

Possible Issues

  1. Breaking Behavior of getServerApiUrl: The updated implementation of getServerApiUrl might result in different outputs compared to the previous version, especially if GITHUB_API_URL is set or the provided URL has specific formats. This could affect existing workflows relying on the original behavior.

Security Hotspots

None identified.

Changes

Changes

  1. CHANGELOG.md

    • Added entries for version 4.2.2:
      * `url-helper.ts` now leverages well-known environment variables by @jww3 in https://github.com/actions/checkout/pull/1941
      * Expand unit test coverage for `isGhes` by @jww3 in https://github.com/actions/checkout/pull/1946
  2. Unit Tests: __test__/url-helper.test.ts

    • Added comprehensive tests for:
      • getServerUrl
      • isGhes
      • getServerApiUrl
  3. Main File: dist/index.js

    • Refactored getServerUrl to use a helper function for content validation (hasContent).
    • Improved getServerApiUrl to utilize well-known environment variables and handle different URL formats more flexibly.
    • Updated isGhes to consider more conditions beyond the basic hostname check.
    • Added helper functions pruneSuffix and hasContent, along with an enum for WhitespaceMode.
  4. Configuration File: package.json

    • Bumped version from 4.2.1 to 4.2.2.
  5. Helper File: src/url-helper.ts

    • Similar changes as in dist/index.js:
      • Enhanced getServerUrl, getServerApiUrl, and isGhes.
      • Added pruneSuffix, hasContent functions, and WhitespaceMode enum for cleaner code.

Copy link

anthropic debug - [puLL-Merge] - actions/[email protected]

Description

This PR updates the checkout action to version 4.2.2, introducing improvements to the URL handling logic and expanding test coverage. The main changes focus on leveraging environment variables for server and API URLs, and refining the logic for determining if a URL is for GitHub Enterprise Server (GHES).

Changes

Changes

  1. CHANGELOG.md:

    • Added entries for version 4.2.2, mentioning improvements in url-helper.ts and expanded unit test coverage.
  2. __test__/url-helper.test.ts:

    • Added new test file with comprehensive tests for getServerUrl, isGhes, and getServerApiUrl functions.
    • Tests cover various scenarios including different URL formats and environment variable configurations.
  3. dist/index.js:

    • Updated the compiled JavaScript code to reflect changes in the TypeScript source.
  4. package.json:

    • Bumped version from 4.2.1 to 4.2.2.
  5. src/url-helper.ts:

    • Refactored getServerUrl to prioritize the GITHUB_SERVER_URL environment variable.
    • Updated getServerApiUrl to use the GITHUB_API_URL environment variable when available.
    • Improved isGhes function to handle more edge cases, including GitHub Enterprise Cloud and localhost URLs.
    • Added helper functions pruneSuffix, hasContent, and WhitespaceMode enum for string manipulation and validation.

Possible Issues

No major issues identified. The changes appear to be well-tested and improve the robustness of the URL handling logic.

Security Hotspots

No significant security hotspots identified. The changes primarily focus on improving URL handling and don't introduce any obvious security risks.

Copy link

bedrock debug - [puLL-Merge] - actions/[email protected]

Description

This PR introduces several improvements to the actions/checkout repository, focusing on enhancing the URL handling functionality and expanding test coverage. The changes primarily affect the url-helper.ts file and its corresponding test file.

Changes

Changes

  1. CHANGELOG.md:

    • Added entries for version 4.2.2, mentioning improvements to url-helper.ts and expanded unit test coverage.
  2. __test__/url-helper.test.ts:

    • Added a new test file with comprehensive test cases for getServerUrl, isGhes, and getServerApiUrl functions.
    • Includes tests for various scenarios, including different URL formats and environment variable configurations.
  3. dist/index.js:

    • Updated the compiled JavaScript code to reflect changes in the TypeScript source.
  4. package.json:

    • Bumped the version number from 4.2.1 to 4.2.2.
  5. src/url-helper.ts:

    • Refactored getServerUrl function to prioritize the GITHUB_SERVER_URL environment variable.
    • Updated getServerApiUrl function to handle different URL formats and use the GITHUB_API_URL environment variable.
    • Enhanced isGhes function to better detect GitHub Enterprise Server instances.
    • Added helper functions pruneSuffix, hasContent, and an enum WhitespaceMode for improved string handling.

Possible Issues

No major non-security issues are apparent in this change. The modifications appear to be well-tested and improve the overall functionality of the URL handling in the action.

Security Hotspots

No significant security hotspots are identified in this PR. The changes primarily focus on improving URL handling and do not introduce any obvious security risks.

@thypon thypon merged commit 2e0bb68 into main Oct 30, 2024
8 checks passed
@thypon thypon deleted the renovate/actions-checkout-4.x branch October 30, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant