Skip to content

Commit

Permalink
fix a typo and url
Browse files Browse the repository at this point in the history
  • Loading branch information
stoletheminerals committed Oct 21, 2024
1 parent d739070 commit 45f172b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion assets/semgrep_rules/client/reinterpret_cast.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ rules:
thypon
cdesouza-chromium
languages: [cpp]
message: "Using `reinterpret_cast` against some data types may lead to undefined bheaviour. In general, when needing to do these conversions, check how Chromium upstream does them. Most of the times a reinterpret_cast is wrong and there's no guarantee the compiler will generate the code that you thought it would."
message: "Using `reinterpret_cast` against some data types may lead to undefined behaviour. In general, when needing to do these conversions, check how Chromium upstream does them. Most of the times a reinterpret_cast is wrong and there's no guarantee the compiler will generate the code that you thought it would."
severity: WARNING
patterns:
- pattern: reinterpret_cast<$T>($ARG)
Expand Down
2 changes: 1 addition & 1 deletion assets/semgrep_rules/client/unsafe-cpp-constructs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ rules:
author: Artem Chaikin
references:
- https://github.com/brave/brave-browser/wiki/Security-reviews
source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/client/unsafe_cpp_constructs.yaml
source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/client/unsafe-cpp-constructs.yaml
assignees: |
stoletheminerals
thypon
Expand Down

0 comments on commit 45f172b

Please sign in to comment.