refine the regex and add more tests

brave · Nov 1, 2024 · e3492da · e3492da
1 parent 54b1aac
commit e3492da
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/assets/semgrep_rules/client/dangling-pointer-trait.cc b/assets/semgrep_rules/client/dangling-pointer-trait.cc
@@ -29,3 +29,8 @@ const raw_ref<const AppListConfig, DanglingUntriaged> app_list_config_;
 const raw_ref<base::WaitableEvent, AcrossTasksDanglingUntriaged> on_destroyed_;
 // ruleid: dangling-pointer-trait
 const raw_ref<AshProxy, LeakedDanglingUntriaged> ash_;
+// ruleid: dangling-pointer-trait
+const raw_ptr<Delegate, AllowPtrArithmetic | FlakyDanglingUntriaged | LeakedDanglingUntriaged> delegate_;
+// ruleid: dangling-pointer-trait
+const raw_ptr<Delegate, AllowPtrArithmetic 
+                                         | FlakyDanglingUntriaged> delegate_;
diff --git a/assets/semgrep_rules/client/dangling-pointer-trait.yaml b/assets/semgrep_rules/client/dangling-pointer-trait.yaml
@@ -9,7 +9,7 @@ rules:
         stoletheminerals
         thypon
         cdesouza-chromium
-    pattern-regex: \braw_(ptr|ref)<[^,>]+,\s*(DanglingUntriaged|DisableDanglingPtrDetection|FlakyDanglingUntriaged|AcrossTasksDanglingUntriaged|AllowPtrArithmetic|AllowUninitialized|LeakedDanglingUntriaged|VectorExperimental|SetExperimental|CtnExperimental)\b\s*>
+    pattern-regex: \braw_(ptr|ref)<[^,>]+,\s*(?:\b(DanglingUntriaged|DisableDanglingPtrDetection|FlakyDanglingUntriaged|AcrossTasksDanglingUntriaged|AllowPtrArithmetic|AllowUninitialized|LeakedDanglingUntriaged|VectorExperimental|SetExperimental|CtnExperimental)\b(?:\s*\|\s*)?){1,}\s*>
     message: "Detected use of a trait that disables dangling pointer checks. This requires security team approval."
     severity: WARNING
     languages: