Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @slack/web-api to v7.0.4 #574

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 24, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@slack/web-api (source) 7.0.2 -> 7.0.4 age adoption passing confidence

Release Notes

slackapi/node-slack-sdk (@​slack/web-api)

v7.0.4: @​slack/[email protected]

Compare Source

What's Changed

We released a fix for the oauth.v2.exchange method argument type; previously it did not require a token, which was incorrect. It now requires a token parameter, which matches the expectations of this API method.

Full Changelog

ae755dc web-api(fix): oauth.v2.exchange method requires a token parameter (#​1779) - thanks for reporting @​iggyray!

v7.0.3

Compare Source

What's Changed

We've deprecated the files.upload method. Check out our announcement on the topic here. Instead, use the uploadV2 method provided by the client.

Full Changelog

ae9ace8 web-api(fix): fix node-retry types (#​1772) - thanks @​cotsupa!
fec4895 web-api(docs): Add deprecation JSdoc to files.upload method (#​1773)
8bff32f web-api(fix): Fix typo in error throwing for rate limit exceeded (#​1755) - thanks @​WhiteKiwi!


Configuration

📅 Schedule: Branch creation - "* 0-4 * * 3" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner April 24, 2024 02:02
@renovate renovate bot force-pushed the renovate/slack-web-api-7.x-lockfile branch from 3f6caa7 to 87c54ea Compare April 25, 2024 09:03
Copy link

[puLL-Merge] - slackapi/node-slack-sdk@@slack/[email protected]..@slack/[email protected]

Description

This PR makes several changes across multiple packages in the node-slack-sdk repository:

  • Updates CI build configuration to add oauth package
  • Adds a new doctor CLI hook to return runtime information
  • Adds a new border property to RichTextQuote block element in @slack/types
  • Updates @slack/rtm-api to target Node 18+ and updates various dependencies
  • Adds integration tests for @slack/rtm-api
  • Updates types for various Web API methods and events in @slack/web-api
  • Adds integration tests for @slack/socket-mode
  • Updates quicktype dependency in scripts

The main motivation seems to be updating the supported Node.js versions for certain packages to 18+, adding some new functionality like the doctor CLI hook, and improving test coverage with new integration tests.

Changes

Changes

.github/workflows/ci-build.yml:

  • Adds oauth package to CI build matrix

packages/cli-hooks:

  • Adds new doctor hook to return runtime version information
  • Bumps package version to 1.1.0

packages/rtm-api:

  • Updates supported Node version to 18+
  • Updates various dependencies to latest versions
  • Adds integration tests

packages/socket-mode:

  • Handles new Event.ServerExplicitDisconnect event
  • Adds integration tests for various scenarios

packages/types:

  • Adds border property to RichTextQuote block element

packages/web-api:

  • Adds types for new arguments/responses for various Web API methods
  • Deprecates files.upload method in favor of files.uploadV2
  • Bumps package version to 7.0.4

scripts/package.json:

  • Updates quicktype dependency to latest version

Security Hotspots

No major security issues jumped out in this PR. A few areas to double check:

packages/rtm-api:

  • The switch to using websocket.on('message',...) instead of addEventListener for handling websocket messages. Make sure this doesn't introduce any unexpected behavior.

packages/socket-mode:

  • The new handling around disconnection events and reasons looks fine, but is worth verifying it doesn't introduce any edge cases that could be exploited.

Overall this PR looks like a solid set of updates and improvements. The new integration tests are great to see. I'd suggest thoroughly testing the changed packages, especially rtm-api and socket-mode, to verify no regressions or unexpected behaviors were introduced. But nothing jumped out as particularly risky from a security perspective. Nice work!

@thypon thypon merged commit 83ab444 into main Apr 29, 2024
8 checks passed
@thypon thypon deleted the renovate/slack-web-api-7.x-lockfile branch April 29, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant