Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "anonymous" and "anonymized" from claim list #643

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Remove "anonymous" and "anonymized" from claim list #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c52f062
Remove "anonymous" and "anonymized" from claim list
ShivanKaul Jun 27, 2024
85fb08e
Remove tests
ShivanKaul Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions assets/semgrep_rules/client/privacy.grd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,10 +623,6 @@ Or change later at <ph name="SETTINGS_EXTENIONS_LINK">$2<ex>brave://settings/ext
Dismiss Brave search conversion, press Enter to remove this suggestion
</message>
<!-- web Discovery InfoBar -->
<message name="IDS_WEB_DISCOVERY_INFOBAR_MESSAGE" desc="The text for web discovery infobar message">
// ruleid: privacy
Help improve <ph name="SEARCH_NAME">$1<ex>Brave Search</ex></ph> by sending anonymous usage data. <ph name="MORE_INFO">$2<ex>More info</ex></ph>
</message>
<message name="IDS_WEB_DISCOVERY_INFOBAR_MESSAGE_BRAVE_SEARCH" desc="The text for brave search part in message">
Brave Search
</message>
Expand Down Expand Up @@ -700,10 +696,6 @@ Or change later at <ph name="SETTINGS_EXTENIONS_LINK">$2<ex>brave://settings/ext
<message name="IDS_SETTINGS_WEB_DISCOVERY_LABEL" desc="Description that shows settings for toggle Web Discovery">
Web Discovery Project
</message>
<message name="IDS_SETTINGS_WEB_DISCOVERY_SUBLABEL" desc="Description that shows under main toggle setting for Web Discovery">
// ruleid: privacy
Contribute some anonymous search &amp; browsing data to refine Brave Search.
</message>

<!-- Brave Tooltips -->
<message name="IDS_BRAVE_TOOLTIPS_BRAVE_TOOLTIP_ACCESSIBLE_NAME" desc="Text to be spoken when a tooltip is shown">
Expand Down
6 changes: 1 addition & 5 deletions assets/semgrep_rules/client/privacy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
// ruleid: privacy
test completely private
// ruleid: privacy
test anonymous
// ruleid: privacy
test anonymized
// ruleid: privacy
test military grade
// ruleid: privacy
test military-grade
Expand All @@ -17,4 +13,4 @@ test unhackable
// ruleid: privacy
test hackerproof
// ruleid: privacy
test hacker-proof
test hacker-proof
2 changes: 0 additions & 2 deletions assets/semgrep_rules/client/privacy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ rules:
severity: WARNING
pattern-either:
- pattern: "completely private"
- pattern: "anonymous"
- pattern: "anonymized"
- pattern: "military grade"
- pattern: "military-grade"
- pattern: "totally secure"
Expand Down