sendSlackMessage: don't send again if the there it increased by one f… #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inding every time use filteredMessage as a way to prevent over notification on slack. This would not send again any notification if there is an extra finding on a given PR, for the previous 50 message, or a day ago. This would debounce chaingun messages in any slack channel from the main action itself. It should not have any other side-effect. This will effectively change the hash function, so invalidate the debounce for all the previous messages.
diracdeltas
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…inding every time
use filteredMessage as a way to prevent over notification on slack. This would not send again any notification if there is an extra finding on a given PR, for the previous 50 message, or a day ago.
This would debounce chaingun messages in any slack channel from the main action itself.
It should not have any other side-effect.
This will effectively change the hash function, so invalidate the debounce for all the previous messages.