Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass '...' through to chart.TimeSeries() functions #183

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

joshuaulrich
Copy link
Collaborator

This allows users to provide arguments to plot.xts() that aren't explicit arguments to the chart.TimeSeries() functions.

For example, it allows users to remove the dates from the top right of the plot:

set.seed(21)
returns <- xts(rnorm(100, 0, 0.005), .Date(1:100))
chart.CumReturns(returns, main.timespan = FALSE)

This doesn't work with the current code, but does with this patch.

This allows users to provide arguments to plot.xts() that aren't
explicit arguments to the chart.TimeSeries() functions.

For example, it allows users to remove the dates from the top right of
the plot:

   set.seed(21)
   returns <- xts(rnorm(100, 0, 0.005), .Date(1:100))
   chart.CumReturns(returns, main.timespan = FALSE)

This doesn't work with the current code.
Should have been included in previous commit.
@braverock braverock merged commit 3e46f41 into master Oct 24, 2023
5 checks passed
@joshuaulrich joshuaulrich deleted the add-dots-to-chart.TimeSeries branch January 25, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants