🐛 user get consumables if having ♻️ refactor of mentorshipService

[lumi-tip]

Issue: breatheco-de/breatheco-de#7659

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 19, 2024 10:35pm

[tommygonzaleza]

It has extra non-necessary validations, if the service.academy.available_as_saas === true then you should always check their consumables, if it's false, then you shouldn't check them because there are no existing consumables for non-saas academies.

[lumi-tip]

When coming from the "choose-program" page, services are assigned the available_as_saas key, as seen here:

const getServices = async (userRoles) => {
    if (userRoles?.length > 0) {
      delete axios.defaults.headers.common.Academy;
      const mentorshipPromises = await userRoles.map((role) => bc.mentorship({ academy: role?.academy?.id }, true).getService()
        .then((resp) => {
          const data = resp?.data;
          if (data !== undefined && data.length > 0) {
            return data.map((service) => ({
              ...service,
              academy: {
                id: role?.academy.id,
                available_as_saas: role?.academy?.available_as_saas,
              },
            }));
          }
          return [];
        }));
      const mentorshipResults = await Promise.all(mentorshipPromises);
      const recopilatedServices = mentorshipResults.flat();

      setMentorshipServices({
        isLoading: false,
        data: recopilatedServices,
      });
    }
  };

I think this is necessary because a user could have different services from different cohorts, so we need to differentiate between them. However, when we're already in a specific program, there’s no need to run this function again, as the cohort itself already tells us whether available_as_saas is true or false. That’s why I kept the useEffect on line 132 in the mentoring component. however I understand that is not completelly clear so i will change the name cohortSessionIsSaaS for better clarity.

[tommygonzaleza]

Avoid nested conditions if possible.

if (allMentorsAvailable.length === 0) {
    servWithMentorsAvailable = getAllServicesWithMentors();
    return;
}

Using a code like this will make it cleaner and easier to understand the condition

[tommygonzaleza]

You are validating this condition twice, maybe you need this condition to happen before and with a return like shown in the previous comment

[tommygonzaleza]

This way you won't need to validate this condition on every if statement

[tommygonzaleza]

Instead of an if... else..., only validate the error's condition, the code should look like this:

if(!serviceFound){
    toast({
          position: 'top',
          title: 'Error',
          description: `${t('supportSideBar.service-not-found')} "${queryService}" ${queryMentor ? `${t('supportSideBar.for')} "${queryMentor}"` : ''}`,
          status: 'error',
          duration: 7000,
          isClosable: true,
    });
    return;
}

handleService(serviceFound);
setOpen(true);
setShouldHandleService(false);

Making it cleaner again and easier to understand

[tommygonzaleza]

onClick={reset}

[tommygonzaleza]

else setDenyAccessToEvent(false);