Skip to content

Commit

Permalink
Fix search path for ios build.
Browse files Browse the repository at this point in the history
Search paths are taken in the order they are written so we can't
use them as a mechanism to choose the target. The user should
copy the framework related to his specific architecture to the
binding.framework folder. This enable the automatic build also
to use this mechanism when building for release.
  • Loading branch information
roeierez committed Jul 15, 2021
1 parent adb4bac commit 45d3bf3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
brew install ideviceinstaller ios-deploy
git clone https://github.com/flutter/flutter.git -b stable
cp -r $GOPATH/src/github.com/breez/breez/build/ios/bindings.xcframework $GITHUB_WORKSPACE/ios/bindings.framework
cp -r $GOPATH/src/github.com/breez/breez/build/ios/bindings.xcframework/ios-arm64/Bindings.framework $GITHUB_WORKSPACE/ios/bindings.framework
rm -rf $GITHUB_WORKSPACE/conf
git clone [email protected]:configuration -b production $GITHUB_WORKSPACE/temp_config
cp -r $GITHUB_WORKSPACE/temp_config/conf $GITHUB_WORKSPACE/conf
Expand Down
8 changes: 2 additions & 6 deletions ios/Runner.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -626,9 +626,7 @@
FRAMEWORK_SEARCH_PATHS = (
"$(inherited)",
"$(PROJECT_DIR)/Flutter",
"$(PROJECT_DIR)",
"$(PROJECT_DIR)/bindings.framework/ios-arm64_x86_64-simulator/",
"$(PROJECT_DIR)/bindings.framework/ios-arm64",
"$(PROJECT_DIR)",
);
INFOPLIST_FILE = Runner/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 12.1;
Expand Down Expand Up @@ -666,9 +664,7 @@
FRAMEWORK_SEARCH_PATHS = (
"$(inherited)",
"$(PROJECT_DIR)/Flutter",
"$(PROJECT_DIR)",
"$(PROJECT_DIR)/bindings.framework/ios-arm64_x86_64-simulator/",
"$(PROJECT_DIR)/bindings.framework/ios-arm64",
"$(PROJECT_DIR)",
);
INFOPLIST_FILE = Runner/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 12.1;
Expand Down

0 comments on commit 45d3bf3

Please sign in to comment.