Skip to content

Commit

Permalink
Fix the docker pull command: disable the timeout and show the… (#400)
Browse files Browse the repository at this point in the history
Fix the `docker pull` command: disable the timeout and show the correct error
  • Loading branch information
mnapoli authored Aug 9, 2019
2 parents 36321cd + 2755ecd commit 6de2ceb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion bref
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ $app->command('dashboard [--port=]', function (int $port = 8000, SymfonyStyle $i
$io->writeln("Stack: <fg=yellow>$stack ($region)</>");

$dockerPull = new Process(['docker', 'pull', 'bref/dashboard']);
$dockerPull->setTimeout(null);
$dockerPull->start();
do {
$animation->tick('Retrieving the latest version of the dashboard');
Expand All @@ -313,7 +314,7 @@ $app->command('dashboard [--port=]', function (int $port = 8000, SymfonyStyle $i
if (! $dockerPull->isSuccessful()) {
$io->error([
'The command `docker pull bref/dashboard` failed',
$servelessInfo->getErrorOutput(),
$dockerPull->getErrorOutput(),
]);

return 1;
Expand Down

0 comments on commit 6de2ceb

Please sign in to comment.