Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the ftrace buffer instances #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use the ftrace buffer instances #38

wants to merge 1 commit into from

Conversation

phantez
Copy link

@phantez phantez commented Sep 24, 2015

If ftrace is already in use without instances, options are inherited and it prevents the logging to work as expected for the pertf-tools CLIs.

@brendangregg : It's a very simplistic approach to the problem, not sure you want to merge that like it, but it's mainly a heads up if some other people are running into the same issues as I did.

If ftrace is already in use without instances, options are inherited and it
prevents the logging to work as expectd.
@phantez
Copy link
Author

phantez commented Sep 24, 2015

BTW, if you are interested I can clean that pull request to make it a bit nicer, like variables to avoid duplication of the long path, etc..

@brendangregg
Copy link
Owner

Thanks; I'll eventually switch perf-tools over to use buffer instances when they are available (Linux version ??). Since every tool is going to get a chunk of boilerplate, it might be time to move it into its own library. Although I'll try hard not to break the copy-n-paste virtue of stand-alone tools: perhaps I'll make perf-tools "build" stand-alone tools which are committed in github, but we actually develop them in a src directory.

@psanford
Copy link

This would have been useful for me this week. Specifically, I wanted to run uprobe multiple times. If there was an option to make a new (ephemeral) trace instance per invocation that would have made things a lot easier for me.

@psanford
Copy link

This would have been useful for me this week. Specifically, I wanted to run uprobe multiple times. If there was an option to make a new (ephemeral) trace instance per invocation that would have made things a lot easier for me.

Hmm. Looking at this some more it doesn't seem like you can set uprobes on a trace instance (at least on my 5.4 kernel).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants