add ctl lookup traits

starky/src/lib.rs

@@ -355,5 +355,6 @@ pub mod verifier;
 pub mod fibonacci_stark;
 #[cfg(test)]
 pub mod permutation_stark;
+
 #[cfg(test)]
 pub mod unconstrained_stark;

starky/src/lookup.rs

@@ -385,7 +385,7 @@ impl<F: Field> Column<F> {
         } else {
             vs.extend(v);
         }
-        assert_eq!(vs.len(), self.linear_combination.len());
+        // assert_eq!(vs.len(), self.linear_combination.len());
         let pairs = self
             .linear_combination
             .iter()
@@ -878,6 +878,8 @@ pub(crate) fn eval_packed_lookups_generic<F, FE, P, S, const D: usize, const D2:
     let p2_local_values = p2_vars.is_some().then(|| p2_vars.unwrap().get_local_values());
     let p2_next_values = p2_local_values.is_some().then(||p2_vars.unwrap().get_next_values());
 
+    println!("local_values: {:?}, p2_local_values: {:?}", local_values, p2_local_values);
+
     let degree = stark.constraint_degree();
     let mut start = 0;
     for lookup in lookups {

starky/src/prover.rs

@@ -724,12 +724,14 @@ fn check_constraints<'a, F, C, S, const D: usize>(
 
     // Assert that all constraints evaluate to 0 over our subgroup.
     for (row, v) in constraint_values.iter().enumerate() {
-        for x in v.iter() {
+        println!("constraits {}", v.iter().len());
+        for (c, x) in v.iter().enumerate() {
             assert!(
                 x.is_zero(),
-                "Constraint failed in {} at row {}",
+                "Constraint failed in {} at row {}, position {}",
                 type_name::<S>(),
-                row
+                row,
+                c,
             )
         }
     }

starky/src/stark.rs

@@ -17,7 +17,7 @@ use plonky2::plonk::circuit_builder::CircuitBuilder;
 use crate::config::StarkConfig;
 use crate::constraint_consumer::{ConstraintConsumer, RecursiveConstraintConsumer};
 use crate::evaluation_frame::{StarkEvaluationFrame};
-use crate::lookup::Lookup;
+use crate::lookup::{Column, Filter, Lookup};
 
 
 /// Represents a STARK system.
@@ -269,6 +269,17 @@ pub trait Stark<F: RichField + Extendable<D>, const D: usize>: Sync {
         vec![]
     }
 
+    /// Outputs all Cross LookUp Columns this table needs to perform
+    fn ctl_columns(&self) -> Vec<Column<F>> {
+        vec![]
+    }
+
+    /// CTL filter for the final block rows of the table.
+    fn clt_filter(&self) -> Filter<F> {
+        Filter::default()
+    }
+
+
     /// Outputs the number of total lookup helper columns, based on this STARK's vector
     /// of [`Lookup`] and the number of challenges used by this [`StarkConfig`].
     fn num_lookup_helper_columns(&self, config: &StarkConfig) -> usize {