-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Persian translation for before and after #2941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. 🙏
@azim-kordpour you seem to have misunderstood the semantics of what you have changed. These are relative to another time, not "now", so the previous translation was correct, and you have made it incorrect. |
@kylekatarnls please revert this. |
Hello @mokhosh and @azim-kordpour, just to double check the semantic can you please translate parts in brackets here:
|
So, it depends whether you use this Carbon feature, to mention both times that you're comparing, or you just mention one. And this would be a breaking change for those who rely on the previous semantics. This article has been edited {{ $updated_at->diffForHumans($created_at) }} it was created. |
@mokhosh You are right, it would be a breaking change in some cases. @kylekatarnls these commits should be reverted |
Hi,
Persian is my mother tongue and these little changes make a meaningful translation in which developers use methods like diffForhumans.
An example in English would be like this:
2 years back
2 years forward
Although they might be right, they are not common and meaningful.