Internal: Separate <string.h> polyfills from OPENSSL_mem*.
#1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `OPENSSL_memset` and `OPENSSL_memcpy` diverged from BoringSSL by providing a fallback implementation for when we can't use <string.h>. Separate out those fallbacks into `RING_mem*` and re-sync `OPENSSL_mem*` with BoringSSL, except using `RING_mem*` in their implementations instead of the C standard library functions. Re-sync aes_nohw.c with BoringSSL in the same manner.
Codecov Report
@@ Coverage Diff @@
## main #1781 +/- ##
==========================================
- Coverage 96.01% 95.95% -0.06%
==========================================
Files 138 139 +1
Lines 20788 20788
Branches 226 226
==========================================
- Hits 19959 19948 -11
- Misses 792 802 +10
- Partials 37 38 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
OPENSSL_memsetandOPENSSL_memcpydiverged from BoringSSL by providing a fallback implementation for when we can't use <string.h>. Separate out those fallbacks intoRING_mem*and re-syncOPENSSL_mem*with BoringSSL, except usingRING_mem*in their implementations instead of the C standard library functions.Re-sync aes_nohw.c with BoringSSL in the same manner.