RSA signature verification: Avoid wasteful key re-serialization. #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we added `rsa::PublicKey` we changed the `ring::signature` RSA implementation to construct an `rsa::PublicKey` and then verify the signature using it. Unfortunately for backward compatibility with old uses of `RsaKeyPair`, `rsa::PublicKey` constructor constructs (and allocates) a copy of the ASN.1-serialized public key. This is not acceptable for users who are using `ring::signature` to verify a single signature. Refactor `PublicKey` so that it can be bypassed by the `ring::signature` implementation. This is a step towards implementing allocation-free RSA signature verification.
Codecov Report
@@ Coverage Diff @@
## main #1790 +/- ##
==========================================
- Coverage 96.02% 96.02% -0.01%
==========================================
Files 138 138
Lines 20794 20816 +22
Branches 226 226
==========================================
+ Hits 19968 19988 +20
- Misses 790 792 +2
Partials 36 36
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added
rsa::PublicKeywe changed thering::signatureRSA implementation to construct anrsa::PublicKeyand then verify the signature using it. Unfortunately for backward compatibility with old uses ofRsaKeyPair,rsa::PublicKeyconstructor constructs (and allocates) a copy of the ASN.1-serialized public key. This is not acceptable for users who are usingring::signatureto verify a single signature. RefactorPublicKeyso that it can be bypassed by thering::signatureimplementation.This is a step towards implementing allocation-free RSA signature verification.