RSA: Remove QQ from RsaKeyPair. #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1799 +/- ##
==========================================
- Coverage 96.01% 96.01% -0.01%
==========================================
Files 137 137
Lines 20781 20752 -29
Branches 226 226
==========================================
- Hits 19953 19924 -29
+ Misses 795 794 -1
- Partials 33 34 +1
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
QQ comprised almost 25% of the bulk of RsaKeyPair and is actually completely unnecessary since `elem_reduced` can do the whole reduction itself. This has the nice and important side effect of eliminating some conversion operations between `bigint` types. This is also a step towards eliminating some of the `unsafe trait` stuff that kinda-but-not-really modeled modulus relationships.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QQ comprised almost 25% of the bulk of RsaKeyPair and is actually completely unnecessary since
elem_reducedcan do the whole reduction itself.This has the nice and important side effect of eliminating some conversion operations between
biginttypes.This is also a step towards eliminating some of the
unsafe traitstuff that kinda-but-not-really modeled modulus relationships.