Expand frame on single click #248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change, updates both the scrollbar policy and the visibility.
Computes the dimension as if a vertical scrollbar was needed. Otherwise, the layout can enter a loop: Because the view port width is called once with full width, which computes a canvas with a taller dimension than viewport. This triggers the horizontal scrollbar to be added, which triggers another layout. In this layout, the view port width is shorter by the scrollbar width, which makes the canvas fitting in the view port, which then triggers annoter layout that removes the vertical scrollbar, and then starts again. Note the scrollbar visibility is updated at the end of this control block
Fixes a jittering rendering when the viewport height was higher than flamegraph height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-05-22.at.18.38.17.mov