Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Serializable WriteData #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement Serializable WriteData #1

wants to merge 1 commit into from

Conversation

Suficio
Copy link

@Suficio Suficio commented Apr 17, 2020

Allow serialising WriteData, which is useful...

@Suficio
Implement Serializable WriteData
e42d3a0 
Allow serialising WriteData
@qoh
Copy link
Contributor

qoh commented Apr 24, 2020 •
edited
Loading

This should probably be behind an optional serde feature, so that consumers who do not need this don't have to pull in serde, serde_derive, and the whole proc macro kit it depends on.

qoh
qoh suggested changes Apr 24, 2020
View reviewed changes
Cargo.toml
uuid = { version = "0.7", features = ["v5", "serde"] }
Copy link
Contributor

@qoh qoh Apr 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the v5 feature enabled here? It doesn't seem to be used.

src/lib.rs
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This diff isn't necessary for this change

@qoh qoh added the enhancement New feature or request label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qoh qoh qoh requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Suficio @qoh