Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix related link edit pagination #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brewt
Copy link
Contributor

@brewt brewt commented Feb 26, 2014

$id arg wasn't being preserved on pagination causing a fatal error.
Modified the template to just do the same thing that
edit_related_media.html does.

$id arg wasn't being preserved on pagination causing a fatal error.
Modified the template to just do the same thing that
edit_related_media.html does.
@theory
Copy link
Member

theory commented Feb 27, 2014

I've made you a committer, @brewt, so you can merge these commits yourself. Since they're bug fixes, please merge them into both master and rel-2.0.

BTW, are you running the full devtest test suite?

@brewt
Copy link
Contributor Author

brewt commented Mar 4, 2014

Not yet unfortunately. I've been working on a client dev install and haven't had a chance to set up a local instance to run the tests on.

@phillipadsmith
Copy link
Member

➜ bricolage-2.1.0 git:(brewt-related_story_paging_fix) ✗ sudo make devtest
PERL_DL_NONLAZY=1 /Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.1/bin/perl inst/runtests.pl -d
t/Bric/Test/Runner.pm .. 1/? # expected 41 test(s) in Bric::Util::Pref::DevTest::test_list, 42 completed
t/Bric/Test/Runner.pm .. 11691/? # expected 26 test(s) in Bric::Biz::Asset::Business::Media::Image::DevTest::test_alternate_thumb, 27 completed
t/Bric/Test/Runner.pm .. ok
All tests successful.
Files=1, Tests=12710, 35 wallclock secs ( 1.90 usr 0.15 sys + 21.84 cusr 1.56 csys = 25.45 CPU)
Result: PASS

@theory
Copy link
Member

theory commented Jul 15, 2014

Merge it into master and rev-2.0, and note it in the rev-2.0 Changes.

@theory
Copy link
Member

theory commented Feb 13, 2015

Update: Merge it into master and screw rev-2.0. We should just release 2.2.

@phillipadsmith
Copy link
Member

Let me know when I can find you on IRC and I'll give this another go. I got half-way through and hit those failing tests. Now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants