fix(secrets): Multiple matching groups are being caught as regex separated by | sign #6967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (in multiline policy) captured, so matching group will be the match & empty matching as only one pattern caught the secret
pazbechor
requested a deployment
to
scan-security
GitHub Actions
Waiting
pazbechor
changed the title
tsmithv11
approved these changes
Jan 24, 2025
pazbechor
pushed a commit
that referenced
this pull request
Jan 24, 2025
RabeaZr
reviewed
Jan 26, 2025
| if isinstance(regex_matches, tuple): | ||
| for match in regex_matches: | ||
| if match: | ||
| return match |
There was a problem hiding this comment.
what happens if there are multiple capturing groups and the resulting tuple has multiple values? will you just take the first value? why?
ChanochShayner
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
… (in multiline policy) captured, so matching group will be the match & empty matching as only one pattern caught the secret
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Enhances the
CustomRegexDetectorclass to handle multiple matching groups in multiline regex patterns. Introduces a new method_extract_real_regex_matchto extract the first non-empty match from a tuple of regex matches. Updates type hints to accommodate the new functionality.Modified files (1)
Latest Contributors(2)
Modified files (1)
Latest Contributors(2)