Significant refactor of the Routes plugin #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- More modular and OOP - Better Roda plugin layout - Dynamic `index` route now supported instead of static index.html - Downstream plugins can leverage file-based routing themselves
|
Your Render PR Server URL is https://bridgetown-beta-pr-882.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-coecsskf7o1s73ckb610. |
|
Your Render PR Server URL is https://bridgetown-api-pr-882.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-coecsssf7o1s73ckb670. |
|
I should mention here: a longer-term goal is to extract most of this functionality out into a standalone Roda plugin which would be view layer-agnostic, so it could work even with Roda's own |
…plugin - Also serve static `index.html` using the same `Rack::Files` server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some not-particularly-attractive code lurking in the file-based routes plugin. It had been brute-forced to work, and then didn't receive the necessary spit 'n' polish it deserved. This PR provides that.
beforehook anymore, which means end-user developers can leverage it if they so chooseindexroute is now supported instead of staticindex.htmlThat last one is huge, as it means a Bridgetown + Roda site could effectively be a completely dynamic Ruby application! And it closes #736.
Also moved previously monkey-patched Roda Public code into a streamlined standalone SSG plugin (to be extracted out later — it's really just a small wrapper around
Rack::Filesas was the earlier Public plugin), and now it's serving staticindex.htmlusing the sameRack::Filesserver.