dnd: computeDrop hover.atTop check #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edimov
force-pushed
the
feature/compute-drop-sblings
branch
from
255b91c
to
7e58836
Compare
edimov
changed the title
|
This is great. I'm pulling your branch now to run the tests. |
|
I think this is a bug. If a folder is open and has children you should not be able to place an item as the folder's sibling unless you drag it to the bottom of it's child list. Area.mp4 |
|
We could check if the above node isOpen and hasNoChildren, then allow the drop as sibling. Would that work for you? |
|
Awesome! That's the check I've been missing. I've updated with 9bcbf67. Do you think you had something like this in mind? |
|
Ship it! :D |
edimov
force-pushed
the
feature/compute-drop-sblings
branch
from
9bcbf67
to
c9af3ab
Compare
|
Yeah that is what I was thinking. I'll run my own tests again. Let's ship today. |
jameskerr
added a commit
that referenced
this pull request
Dec 13, 2023
Based off #199 Thanks to the understanding and work of @edimov, we can now drop a node as a sibling (or child) of an open, but childless node. This should unlock people who want to create trees where every single node is an open, internal node. Co-authored-by: Evgeni Dimov <[email protected]>
|
Merged in #202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR:
hover.atTopcheck to allow siblings drop on nodes with empty childrencomputeDropcalculations when hovering over same nodeScreenshots
Before
Screen.Recording.2023-12-09.at.20.42.11.mov
After
Screen.Recording.2023-12-09.at.21.23.53.mov