Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Mock version of framework #236

Merged
merged 1 commit into from
Aug 22, 2024
Merged

MNT Mock version of framework #236

merged 1 commit into from
Aug 22, 2024

Conversation

emteknetnz
Copy link
Collaborator

@emteknetnz emteknetnz mentioned this pull request Aug 13, 2024
Closed
11 tasks
@emteknetnz emteknetnz changed the title MNT Prevent extension from fetching from github MNT Mock version of framework Aug 14, 2024
@emteknetnz emteknetnz marked this pull request as ready for review August 19, 2024 22:14
GuySartorelli
GuySartorelli requested changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target 3.1 so we can use this in kitchen sink runs against all supported branches.

@emteknetnz emteknetnz mentioned this pull request Aug 21, 2024
Closed
@emteknetnz
Copy link
Collaborator Author

There's differences between 3.1 and 4 compare and I'm not able to quickly work out the differences, and I require this PR to get the recipe-kitche-sink PR to work correctly

I've raised a new card to backport this to 3.1

GuySartorelli
GuySartorelli approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This isn't related to the other PRs so I'll merge now.

@GuySartorelli GuySartorelli merged commit 392a8c2 into bringyourownideas:4 Aug 22, 2024
8 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/mock-github branch August 22, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli