Refactor existing tests and add new ones

[wlsf82]

For more details, read the commit messages.

See the tests running:

login.spec.js.mp4

models.spec.js.mp4

Cc @ArthurMota9, @idmarjr, and @miltonbsn.

[idmarjr]

Not sure if I'm doing something wrong but one of the tests is failing here:

is this expected?

[wlsf82]

is this expected?

Not it's not. Are you running the tests against your local environment?

Maybe I'll need to increase a timeout since the default one from Cypress might not be enough.

@idmarjr, have you tried more than once? If so, does it always fails on the same step?

[idmarjr]

Yes sir. I'm running it at localhost and tried to run it twice, once using yarn test and another using yarn cy:open, both fail.

Maybe someone else can run the tests as well to double check it?

CC @ArthurMota9 @miltonbsn or @oicramps

[wlsf82]

Yes sir. I'm running it at localhost and tried to run it twice, once using yarn test and another using yarn cy:open, both fail.

Maybe we can pair on it tomorrow so that I can investigate it further.

[wlsf82]

Oddly, only one test is failing.

The beforeEach hook runs before each test, as its name suggests.
This means that, for all other tests, all steps inside of it have passed.

@miltonbsn, maybe you can help us out here.

When visiting the relative URL /#!/main as a logged-in user, should a GET request always happen to retrieve the models of such user (/models?userId=*)?

[miltonbsn]

Oddly, only one test is failing.

The beforeEach hook runs before each test, as its name suggests. This means that, for all other tests, all steps inside of it have passed.

@miltonbsn, maybe you can help us out here.

When visiting the relative URL /#!/main as a logged-in user, should a GET request always happen to retrieve the models of such user (/models?userId=*)?

Hi @wlsf82, yes every time you visite /#!/main we execute a GET request.

brmodelo-app/app/angular/workspace/workspace.js

Line 47 in 3e7b830

ctrl.$onInit = () => {

Is it too slow?

[wlsf82]

@idmarjr, can you pull the new code I pushed today and try again, please?

Let's see if this commit 02c5314 will fix it.

Cc @miltonbsn.

[idmarjr]

Nope. 02c5314 did not solve the issue. 😢

[wlsf82]

Nope. 02c5314 did not solve the issue. 😢

Right after line 10 (the failure), I see that there's a GET request to http://localhost:3000/models, while the test expects a request to http://localhost:3000/models?userId=*.

@miltonbsn, is there a "kind" of user who gets all the models instead of only its own?

[wlsf82]

To keep it documented, we discovered that, on @idmarjr's computer, the failure is related to the use of the experimental feature cy.session. Without it, all tests worked fine.

On everyone else's computer, cy.session works fine .

What happens to on Id's computer is that when using cy.session, the getUserModels request that we are trying to intercept never happens, failing the test in the beforeEach hook.

But, we decided to keep using the feature since it speeds up tests, and in the meanwhile, Id will try it out on another computer.

[wlsf82]

To keep it documented, we discovered that, on @idmarjr's computer, the failure is related to the use of the experimental feature cy.session. Without it, all tests worked fine.

On everyone else's computer, cy.session works fine .

What happens to on Id's computer is that when using cy.session, the getUserModels request that we are trying to intercept never happens, failing the test in the beforeEach hook.

But, we decided to keep using the feature since it speeds up tests, and in the meanwhile, Id will try it out on another computer.

@bahmutov, any thoughts?

[bahmutov]

I would use cypress-data-session and be done with it

…

Sent from my iPhone

On Nov 19, 2021, at 20:12, Walmyr ***@***.***> wrote:  To keep it documented, we discovered that, on @idmarjr's computer, the failure is related to the use of the experimental feature cy.session. Without it, all tests worked fine. On everyone else's computer, cy.session works fine . What happens to on Id's computer is that when using cy.session, the getUserModels request that we are trying to intercept never happens, failing the test in the beforeEach hook. But, we decided to keep using the feature since it speeds up tests, and in the meanwhile, Id will try it out on another computer. @bahmutov, any thoughts? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[wlsf82]

To keep it documented, we discovered that, on @idmarjr's computer, the failure is related to the use of the experimental feature cy.session. Without it, all tests worked fine.

On everyone else's computer, cy.session works fine .

What happens to on Id's computer is that when using cy.session, the getUserModels request that we are trying to intercept never happens, failing the test in the beforeEach hook.

But, we decided to keep using the feature since it speeds up tests, and in the meanwhile, Id will try it out on another computer.

Just to keep it documented, the issue only happens when the server is pointing to a remote MongoDB. If the server points to a local MongoDB everything works fine.