Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function documentation out of date #43

Open
5 tasks
HugoHakem opened this issue Aug 15, 2024 · 1 comment
Open
5 tasks

Function documentation out of date #43

HugoHakem opened this issue Aug 15, 2024 · 1 comment
Labels

Comments

@HugoHakem
Copy link
Collaborator

HugoHakem commented Aug 15, 2024

Few remarks on Jump_portrait
in get_jump_image

  • Would be better if instead of broadcasting the error: "More than one site found", a suggestion of correction was given

  • Would be great to enable to pass a list of str instead of just a str.

  • all the parameters of get_jump_image are not ully explained:

  • example apply_correction vs apply_illum

  • compressed

  • staging

  • tqdm takes a lot of space: let's try something from here, or add a way to disable it.

Workflow 1 and workflow 2

  • parameter corrections is not consistently defined which I think is confusing:

  • corrections = ["Orig"] # Can also be "Illum"

  • correction = None # or "Illum"

@afermg
Copy link
Collaborator

afermg commented Sep 4, 2024

WIP on #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants