Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache canSymlink result to avoid performance penalty #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cache canSymlink result to avoid performance penalty #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,21 @@ function makeFSObjectCleanedUp(p) {
return makeFSObjectCleanedUp(target);
}

// Cache the result of `canSymlink`. Since it uses fs methods
// it is moderately expensive to repeat many times.
let cachedCanSymlink = undefined;
function checkCanSymlink() {
if (cachedCanSymlink === undefined) {
cachedCanSymlink = canSymlink();
}
return cachedCanSymlink;
}

class FSUpdater {
constructor(outputPath, options) {
this.outputPath = outputPath;
if (options == null) options = {};
if (options.canSymlink == null) options.canSymlink = canSymlink();
if (options.canSymlink == null) options.canSymlink = checkCanSymlink();
if (options.retry == null) options.retry = true;
this.options = options;
this._logger = loggerGen("FSUpdater");
Expand Down