Support keyboards with AltGr #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any keys with AltGr would be shown as ctrl+alt+key, so instead of seeing
"{" when pressing AltGr+7 on a Swedish keyboard you would see
Ctrl+Alt+7, and instead of € you would see Ctrl+Alt+e.
With this patch AltGr is treated just as Shift. So when Shift is shown,
so is AltGr, and the other way around.
Since there is no single virtual key representing AltGr, this changes
the representation of modifiers from a string and sometimes a vk,
to a struct of 5 bools. This makes the code simpler and should be
as efficient.
The patch also changes some constants from magical numerical values
to VK_FOO constants.
Otherwise the patch tries to stay as close as possible to the existing
code style for good and bad. It will us fixed size buffers for instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any keys with AltGr would be shown as ctrl+alt+key, so instead of seeing
"{" when pressing AltGr+7 on a Swedish keyboard you would see
Ctrl+Alt+7, and instead of € you would see Ctrl+Alt+e.
With this patch AltGr is treated just as Shift. So when Shift is shown,
so is AltGr, and the other way around.
Since there is no single virtual key representing AltGr, this changes
the representation of modifiers from a string and sometimes a vk,
to a struct of 5 bools. This makes the code simpler and should be
as efficient.
The patch also changes some constants from magical numerical values
to VK_FOO constants.
Otherwise the patch tries to stay as close as possible to the existing
code style for good and bad. It will us fixed size buffers for instance.