Skip to content

Commit

Permalink
Revert "Remove unused rows_affected column in test_executions #195"
Browse files Browse the repository at this point in the history
This reverts commit 9182fdc.
  • Loading branch information
Gemma Down committed Sep 14, 2023
1 parent 9a65852 commit 54aa3fd
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 1 deletion.
5 changes: 4 additions & 1 deletion macros/upload_individual_datasets/upload_test_executions.sql
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
{{ adapter.dispatch('column_identifier', 'dbt_artifacts')(9) }},
{{ adapter.dispatch('column_identifier', 'dbt_artifacts')(10) }},
{{ adapter.dispatch('column_identifier', 'dbt_artifacts')(11) }},
{{ adapter.dispatch('parse_json', 'dbt_artifacts')(adapter.dispatch('column_identifier', 'dbt_artifacts')(12)) }}
{{ adapter.dispatch('column_identifier', 'dbt_artifacts')(12) }},
{{ adapter.dispatch('parse_json', 'dbt_artifacts')(adapter.dispatch('column_identifier', 'dbt_artifacts')(13)) }}
from values
{% for test in tests -%}
(
Expand Down Expand Up @@ -56,6 +57,7 @@
{% endif %}

{{ test.execution_time }}, {# total_node_runtime #}
null, {# rows_affected not available in Databricks #}
{{ 'null' if test.failures is none else test.failures }}, {# failures #}
'{{ test.message | replace("\\", "\\\\") | replace("'", "\\'") | replace('"', '\\"') }}', {# message #}
'{{ tojson(test.adapter_response) | replace("\\", "\\\\") | replace("'", "\\'") | replace('"', '\\"') }}' {# adapter_response #}
Expand Down Expand Up @@ -109,6 +111,7 @@
{% endif %}

{{ test.execution_time }}, {# total_node_runtime #}
null, {# rows_affected not available in Databricks #}
{{ 'null' if test.failures is none else test.failures }}, {# failures #}
'{{ test.message | replace("\\", "\\\\") | replace("'", "\\'") | replace('"', '\\"') | replace("\n", "\\n") }}', {# message #}
{{ adapter.dispatch('parse_json', 'dbt_artifacts')(tojson(test.adapter_response) | replace("\\", "\\\\") | replace("'", "\\'") | replace('"', '\\"')) }} {# adapter_response #}
Expand Down
1 change: 1 addition & 0 deletions macros/upload_results/get_column_name_lists.sql
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@
compile_started_at,
query_completed_at,
total_node_runtime,
rows_affected,
failures,
message,
adapter_response
Expand Down
1 change: 1 addition & 0 deletions models/fct_dbt__test_executions.sql
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ test_executions as (
compile_started_at,
query_completed_at,
total_node_runtime,
rows_affected,
failures,
message
from base
Expand Down
2 changes: 2 additions & 0 deletions models/fct_dbt__test_executions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ models:
description: '{{ doc("node_id") }}'
- name: query_completed_at
description: '{{ doc("query_completed_at") }}'
- name: rows_affected
description: '{{ doc("rows_affected") }}'
- name: status
description: '{{ doc("status") }}'
- name: test_execution_id
Expand Down
1 change: 1 addition & 0 deletions models/sources/test_executions.sql
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ select
cast(null as {{ type_timestamp() }}) as compile_started_at,
cast(null as {{ type_timestamp() }}) as query_completed_at,
cast(null as {{ type_float() }}) as total_node_runtime,
cast(null as {{ type_int() }}) as rows_affected,
cast(null as {{ type_int() }}) as failures,
cast(null as {{ type_string() }}) as message,
cast(null as {{ type_json() }}) as adapter_response
Expand Down
2 changes: 2 additions & 0 deletions models/sources/test_executions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ models:
description: '{{ doc("query_completed_at") }}'
- name: total_node_runtime
description: '{{ doc("total_node_runtime") }}'
- name: rows_affected
description: '{{ doc("rows_affected") }}'
- name: failures
description: '{{ doc("failures") }}'
- name: message
Expand Down
1 change: 1 addition & 0 deletions models/staging/stg_dbt__test_executions.sql
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ enhanced as (
compile_started_at,
query_completed_at,
total_node_runtime,
rows_affected,
failures,
message
from base
Expand Down
2 changes: 2 additions & 0 deletions models/staging/stg_dbt__test_executions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ models:
description: '{{ doc("node_id") }}'
- name: query_completed_at
description: '{{ doc("query_completed_at") }}'
- name: rows_affected
description: '{{ doc("rows_affected") }}'
- name: run_started_at
description: '{{ doc("run_started_at") }}'
- name: status
Expand Down

0 comments on commit 54aa3fd

Please sign in to comment.