Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgres support #368

Merged
merged 24 commits into from
Sep 29, 2023
Merged

Conversation

dpguthrie
Copy link
Contributor

Overview

  • Adds relevant macros to enable support for Postgres
  • Adds a postgres service to the github action used for integration testing
  • Aliased the subquery used in the singular test as it's necessary within Postgres (should work across all other supported DWs)

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)

What does this solve?

Support for a new platform, Postgres

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • Postgres
  • N/A

@dpguthrie dpguthrie temporarily deployed to Approve Integration Tests July 13, 2023 02:37 — with GitHub Actions Inactive
@dpguthrie dpguthrie temporarily deployed to Approve Integration Tests July 13, 2023 02:37 — with GitHub Actions Inactive
@dpguthrie dpguthrie temporarily deployed to Approve Integration Tests July 13, 2023 02:37 — with GitHub Actions Inactive
@dpguthrie
Copy link
Contributor Author

Passing postgres integration tests - https://github.com/dpguthrie/dbt_artifacts/actions/runs/5538393942

@dpguthrie dpguthrie changed the title Feat/add postgres Add postgres support Jul 14, 2023
@glsdown
Copy link
Contributor

glsdown commented Jul 24, 2023

Hi @dpguthrie . Thanks for taking the time to add this functionality in.

One of the team will spend some time reviewing it and get back to you.

@dpguthrie dpguthrie requested a deployment to Approve Integration Tests July 24, 2023 09:10 — with GitHub Actions Waiting
@dpguthrie dpguthrie requested a deployment to Approve Integration Tests July 24, 2023 09:10 — with GitHub Actions Waiting
@dpguthrie dpguthrie requested a deployment to Approve Integration Tests July 24, 2023 09:10 — with GitHub Actions Waiting
@dpguthrie dpguthrie requested a deployment to Approve Integration Tests July 24, 2023 09:10 — with GitHub Actions Waiting
@dpguthrie dpguthrie requested a deployment to Approve Integration Tests July 24, 2023 09:10 — with GitHub Actions Waiting
@dpguthrie dpguthrie requested a deployment to Approve Integration Tests July 24, 2023 09:10 — with GitHub Actions Waiting
@drewblinn
Copy link

Would love to see this in the next release!

@glsdown glsdown mentioned this pull request Sep 28, 2023
3 tasks
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 14:27 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 14:27 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 14:27 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 14:30 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 14:30 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 14:30 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 14:30 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 14:30 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 14:30 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 14:30 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 14:30 — with GitHub Actions Inactive
Copy link
Contributor

@glsdown glsdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this. Sorry it's taken a while to review - there have been a number of changes to improve the backend, so I wanted to make sure those had been made first.

@glsdown glsdown merged commit 069d71c into brooklyn-data:main Sep 29, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants