Fix BigQuery parse_json macro usage #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In #358 there was a change to the parse_json usage for BigQuery, where the macro was updated, but the macro wasn't being used. This replaces the use of
parse_jsonwith the parse_json macro.Update type - breaking / non-breaking
What does this solve?
Outstanding questions
N/A
What databases have you tested with?