Fix bug with calculation of last_run stats for incremental models #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As noted in #372 the way that
last_run_*stats are calculated indim_dbt__current_modelsis incorrect. This aims to fix them, as well as provide 4 additional fields:last_incremental_run_completed_atlast_incremental_run_total_runtimelast_incremental_run_rows_affectedlast_incremental_run_bytes_processed- BQ onlyUpdate type - breaking / non-breaking
What does this solve?
Outstanding questions
What databases have you tested with?