Fix: typo in upload_results to determine batch size #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtkfan
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
rtkfan
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
rtkfan
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
rtkfan
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
approved these changes
Jan 25, 2024
|
Thanks for the spot and contribution @rtkfan! |
|
Thanks for pushing this through @jared-rimmer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a typo in
upload_results()that causes batch sizes for uploading models to be too large for BigQuery only.Update type - breaking / non-breaking
What does this solve?
This typo caused the batch size for models in BigQuery to be too large, causing an error (due to a too-large query size) when uploading models. Testing the same changeset on a different fork in a separate (complex, but private) project successfully uploads models (where using the v2.6.2 release of dbt_artifacts causes the failure).
Outstanding questions
N/A, this is a straightforward fix, I think!
What databases have you tested with?
This changeset passes integration tests in BigQuery. I don't have access to other databases so haven't tested there (however, the change should only affect behaviour in BigQuery).