Patch: Update tox.ini to handle dbt-postgres installing dbt-core prerelease #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtcarlone
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
mtcarlone
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
mtcarlone
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
mtcarlone
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
michelley-an
approved these changes
Oct 4, 2024
|
Postgres is expected to fail here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds an additional dependency in the tox.ini file to ensure dbt-postgres installs dbt-core 1.8.x. Without this dependency, it installs dbt-core 1.9.0b1
Update type - breaking / non-breaking
What does this solve?
This solves open PRs that cannot pass CI due to tox.ini installing a pre-release version of dbt-core for dbt-postgres adapter. This means we violate the
require-dbt-versionparameter in thedbt_project.ymlfle.Outstanding questions
What databases have you tested with?