Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing #445 - adding sqlserver integration tests #450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Testing #445 - adding sqlserver integration tests #450

wants to merge 1 commit into from

Conversation

michelley-an
Copy link
Contributor

@michelley-an michelley-an commented Oct 9, 2024 •
edited
Loading

Overview

This PR is a copy of #445, necessary since we upgraded dbt-artifacts to version 1.7.0. This is a minor bug fix for the sqlserver github action. The bug is the connection to sqlserver in the test_packages and the profiles.yml.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@michelley-an michelley-an requested a deployment to Approve Integration Tests October 9, 2024 20:38 — with GitHub Actions Waiting
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:38 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:38 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:38 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Active
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Inactive
@michelley-an michelley-an had a problem deploying to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Failure
@michelley-an michelley-an had a problem deploying to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Failure
@michelley-an michelley-an had a problem deploying to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Failure
@michelley-an michelley-an had a problem deploying to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Failure
@michelley-an michelley-an had a problem deploying to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Failure
@michelley-an michelley-an had a problem deploying to Approve Integration Tests October 9, 2024 20:42 — with GitHub Actions Failure
@michelley-an
Copy link
Contributor Author

@KijkEr does the integration-sqlserver portion look right? Just want to make sure that I'm not missing anything

@KijkEr
Copy link

KijkEr commented Oct 10, 2024

@michelley-an I think this looks right yes. I got this to work in my fork, so I think it should work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michelley-an @KijkEr @michlyan