-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chris follett #13
base: master
Are you sure you want to change the base?
Chris follett #13
Conversation
Reviewing this now. Some quick thoughts from just reading the above message
|
Will post comments on PR content below as I go:
Overall I feel that this should not require so much new / duplicated code but maybe I am missing something obvious here. |
How are things going with this? Once you are done with the suggested changes, please let me know it's ready for another review. Would be nice to merge this PR soon, so we can add the interpolation from native grid etc, and make this a one step process. |
When do you plan to revise this? In the mean time I outline the single step pipeline @ https://github.com/gaelforget/MarineEcosystemNotebooks/blob/master/OceanColor/04-ClassificationTestbed.ipynb This should include all you need to go from the dropbox content to the csv we want for this |
I built some code to grab the half degree fields from both geo and Darwin and do the OC-CCI water class estimate. Currently, the code does the additional Rirr to Rrs correction on the DARWIN Data. The 'tryJackson' is the important one. I am still new to this GitHub thing so sorry if this is a giant fail. The code is in Julia.