-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Brainerd lab collaboration #190
Conversation
Visit the preview URL for this PR (updated for commit ae3f5a2): https://ccv-brown-edu--pr190-feat-brainerd-lab-6kv5qxdr.web.app (expires Tue, 25 Jul 2023 16:57:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e6225babbaf68dadb99b2906d33811740e5d15cb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the department. Otherwise, looks good!
It probably should be EEOB. Ecology, Evolution, Organisms, and their
Biology are all closely tied but there are so many specialities and
subfields within! For the sake of keeping the dept name short, ecology-evolution somewhat requires organisms and biology and we typically even shorten that to eco-evo, though it might be better to spell it out to ecology-evolution for a more general audience.
…On Fri, Jul 7, 2023, 9:23 AM Robert Gemma ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In schemas/collaborations.yml
<#190 (comment)>
:
> @@ -46,6 +47,7 @@ department: "enum(
'computational-psychiatry',
'sociology',
'ecology',
+ 'ecology-and-evolutionary-biology',
Hmm... definitely looks like there isn't just an "ecology" department.
I'll ask Beth and see if she has any insight!
—
Reply to this email directly, view it on GitHub
<#190 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF5Q5NN5XTDDVNS4JZQKHADXPAEVJANCNFSM6AAAAAA2AXCE2Y>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
@tdivoll I did confirm with her the department name is "Ecology, Evolution, and Organismal Biology." So the short name should be The other collaborations using the "ecology" department are |
I think if we write "ecology-evolution-and-organismal-biology" everywhere (as you have for brainerd) and we use that everywhere, that's the clearest. (I much prefer the long name than the acronym |
…ogy" (department)
I've made #199 to update the other cases as a PR to this one – @RobertGemmaJr feel free to merge it into here if that works for you! |
…nd-organismal-biology fix: use ecology-evolution-and-organismal-biology in place of ecology for the department
Thank you for that! I just merged it in so this PR should be all set? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
I pulled the description right off of Beth's lab's description. I think that's okay?