Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add new definitions to storage landing page #290

Merged
merged 7 commits into from
Oct 9, 2024
Merged

feat: Add new definitions to storage landing page #290

merged 7 commits into from
Oct 9, 2024

Conversation

eldu
Copy link
Contributor

@eldu eldu commented Oct 7, 2024 •
edited
Loading

Screenshot 2024-10-08 at 7 22 51 AM

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 3d646d8):

https://ccv-brown-edu--pr290-feat-descriptions-pprz6f14.web.app

(expires Tue, 15 Oct 2024 17:01:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e6225babbaf68dadb99b2906d33811740e5d15cb

@eldu eldu requested a review from paulstey October 8, 2024 11:23
paulstey
paulstey requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@paulstey paulstey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this, Ellen! Can you please check out my comment about the Brown Digital Repository summary tag?

@eldu
Copy link
Contributor Author

eldu commented Oct 8, 2024

Thanks for your work on this, Ellen! Can you please check out my comment about the Brown Digital Repository summary tag?

@paulstey I checked in with Amar! Updating now !

@eldu eldu requested a review from paulstey October 8, 2024 16:41
s-bessey
s-bessey approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@s-bessey s-bessey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of grammar edits!

services/file-storage-and-transfer/brown-storage.md Outdated Show resolved Hide resolved
services/file-storage-and-transfer/brown-storage.md
of the Brown community using Brown ID’s and groups. Space is allocated to each
research lab or PI with an ITHelp request , security groups are required to define
access to the data. The data is protected locally via snapshots but doesn’t have
geo-redundancy (secondary copy).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a decent place to link to a definition of geo-redundancy and why this might be an issue for data?

services/file-storage-and-transfer/brown-storage.md Outdated Show resolved Hide resolved
services/file-storage-and-transfer/brown-storage.md Outdated Show resolved Hide resolved
services/file-storage-and-transfer/brown-storage.md Outdated Show resolved Hide resolved
paulstey
paulstey approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@paulstey paulstey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, Ellen! Thank you so much!

@eldu eldu merged commit 68dea2b into main Oct 9, 2024
12 checks passed
@eldu eldu deleted the feat-descriptions branch October 9, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulstey paulstey paulstey approved these changes

@s-bessey s-bessey s-bessey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eldu @paulstey @s-bessey